Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dashboard plugin (#37) #105

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Rename dashboard plugin (#37) #105

merged 1 commit into from
Mar 12, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Mar 8, 2021

Signed-off-by: Bishoy Boktor [email protected]

Rename dashboard plugin (#37)
c08dfcd 
Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
mihirsoni approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

kavilla
kavilla reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really small comment that might not be able to be changed.

src/plugins/dashboard/public/application/help_menu/help_menu_util.ts Show resolved Hide resolved
@boktorbb boktorbb requested a review from kavilla March 11, 2021 22:18
kavilla
kavilla approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noted the variable just incase.

@kavilla kavilla merged commit 486a2d4 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
@boktorbb @kavilla
Rename dashboard plugin (#37) (#105)
8904e5e 
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
@boktorbb @kavilla
Rename dashboard plugin (#37) (#105)
eba0768 
Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
@boktorbb @mihirsoni
Rename dashboard plugin (#37) (#105)
d3e2d2d 
Signed-off-by: Bishoy Boktor <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 24, 2023
@SuZhou-Joe
fix: redirect error (opensearch-project#105)
8cc4ea2 
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
@SuZhou-Joe
fix: redirect error (opensearch-project#105)
7a52b90 
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
@SuZhou-Joe @ruanyl
fix: redirect error (opensearch-project#105)
83f7759 
Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirsoni mihirsoni mihirsoni approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boktorbb @mihirsoni @kavilla